made spago and purescript optional (provided); providing basic shell.nix#20
Open
bbarker wants to merge 1 commit intopurescript-concur:mainfrom
Open
made spago and purescript optional (provided); providing basic shell.nix#20bbarker wants to merge 1 commit intopurescript-concur:mainfrom
bbarker wants to merge 1 commit intopurescript-concur:mainfrom
Conversation
Member
|
I suppose purescript and spago should also live in dev dependencies? |
Contributor
Author
|
In principle, they should live in "optionalDevDependencies", but it doesn't exist. If they were in devDependencies, if you install them on a system where there is a version of the package available, but the npm installation of the same package fails, the entire build is halted. Whereas in optionalDependencies, things will keep working fine. Of course, if the user doesn't have spago or purs AND the npm installation fails, well, what can you do :-) it would have failed anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NPM doesn't have the concept of provided dependencies, but we can make dependencies optional. If there is a failure installing the optional dependencies, it won't cause a failure overall. Binaries distributed via npm are a problem on certain OSes (e.g. NixOS) that have somwhat different linking conventions than most Linux distributions. As far as I can tell, this shouldn't affect users not on Nix-based environments (including in my testing).
I also provide a very basic (strictly optional) shell.nix to load the required binaries.