Add minimum GHI limit check from Nollas et al. (2023)#174
Open
AdamRJensen wants to merge 8 commits intopvlib:mainfrom
Open
Add minimum GHI limit check from Nollas et al. (2023)#174AdamRJensen wants to merge 8 commits intopvlib:mainfrom
AdamRJensen wants to merge 8 commits intopvlib:mainfrom
Conversation
Member
Author
|
To make this PR pleasant to review, I'll make follow up PR adding checking of DHI which is somewhat more complex. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/api.rst.in
docs/whatsnewfor all changes. Includes link to the GitHub Issue with
:issue:`num`or this Pull Request with
:pull:`num`. Includes contributor nameand/or GitHub username (link with
:ghuser:`user`).Add the minimum GHI limit test from (10.1016/j.renene.2022.11.056) Quality control procedure for 1-minute pyranometric measurements of global and shadowband-based diffuse solar irradiance by F. Nollas, G. Salazar, & C. Gueymard.
See #172 for further details.