This repository was archived by the owner on Aug 25, 2024. It is now read-only.
Auth and accounts #85
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Install & set up remix-auth, by adding Cred and Session tables to the database, installing & setting up out first strategy, remix-auth-form (with lots of backend code to check passwords, etc.). This does not include a way to create user accounts, nor proper playwright tests (some tests should fail currently). This is not a breaking change because we don't use the database in the app yet for any purpose that would conflict with this change.
Add missing imports of prisma, which exists as a global in development only.
Oops, forgot to remove a test of the "next page after login" redirect sanitizer.
Change the utility function userExists to be called usernameExists, because users can technically be identified with a username or user id. Also make usernameExists use a new (and exported) util function, getUserByUsername, which just runs a prisma query.
Optimization & ease of use, plus we already need to query the User table to check if the user exists, so why not bundle the request for the happy path?
Add a test that expects unauthenticated requests to My Schedule (/my-schedule) to redirect to the login page.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up flows for authorization and creating accounts.