Conversation
|
hey @larsoner 👋 nice to see you here and thanks for opening a PR. I'm hesitant to add more base level dependencies to magicgui. By its nature, magicgui might potentially support many third party types (beyond pint) but shouldn't require those packages for installation. My assumption with pint was that, if someone wants to provide a widget representation of a Lines 56 to 66 in 21ee452 I see that this means that someone can't immediately run all of the examples without additional installations, but if we add pint, then a similar argument could be made for As an alternative, would you support the addition and of an |
Actually I didn't even notice those options. Maybe just a Just let me know if you agree with how and where these should be documented (or if you have other ideas) and I'm happy to adjust this PR to be a documentation update instead 👍 |
agree! i just tried locally, and mkdocs admonition syntax ( |
|
(note also: I just killed the antiquated setup.py file in #595 ... so your conflict is due to that. it can just be removed) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #592 +/- ##
=======================================
Coverage 87.68% 87.68%
=======================================
Files 39 39
Lines 4573 4573
=======================================
Hits 4010 4010
Misses 563 563 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
On my system
pip intstall magicguifollowed by running a variant of the "all of these" example from https://pyapp-kit.github.io/magicgui/widgets/#magicgui I got:I guess
pintis an optional dependency forsuperqt(?) but it seems likemagicguishould require it to make sure all examples work out of the box.