Skip to content

Support using handle for absl::Cord saving a memcpy. #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Support using handle for absl::Cord saving a memcpy. #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 2 additions & 33 deletions pybind11_abseil/absl_casters.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
#ifndef PYBIND11_ABSEIL_ABSL_CASTERS_H_
#define PYBIND11_ABSEIL_ABSL_CASTERS_H_

#include <Python.h>
#include <pybind11/cast.h>
#include <pybind11/pybind11.h>
#include <pybind11/stl.h>
Expand All @@ -46,7 +45,6 @@
#include <cstring>
#include <tuple>
#include <type_traits>
#include <utility>
#include <vector>

#include "absl/cleanup/cleanup.h"
Expand Down Expand Up @@ -620,39 +618,10 @@ struct type_caster<absl::Cord> {

// Conversion part 1 (Python->C++)
bool load(handle src, bool convert) {
// If the source is a bytes/string object, we can avoid a copy by using
// absl::MakeCordFromExternal.
absl::optional<absl::string_view> view;
if (PyUnicode_Check(src.ptr())) {
Py_ssize_t size = 0;
const char* data = PyUnicode_AsUTF8AndSize(src.ptr(), &size);
if (data) {
view = absl::string_view(data, size);
} else {
PyErr_Clear();
}
} else if (PyBytes_Check(src.ptr())) {
view = absl::string_view(PyBytes_AS_STRING(src.ptr()),
PyBytes_GET_SIZE(src.ptr()));
}
if (view.has_value()) {
if (!view->empty()) {
// Bypass StringViewCaster life support as absl::Cord may outlive the
// handle.
src.inc_ref();
value = absl::MakeCordFromExternal(*view, [src] {
PyGILState_STATE gstate = PyGILState_Ensure();
src.dec_ref();
PyGILState_Release(gstate);
});
} else {
value.Clear();
}
return true;
}
auto caster = StringViewCaster();
if (caster.load(src, convert)) {
value = absl::Cord(cast_op<absl::string_view>(std::move(caster)));
absl::string_view view = cast_op<absl::string_view>(std::move(caster));
value = view;
return true;
}
return false;
Expand Down
Loading