Make generated file use valid C++ identifiers#31
Merged
Conversation
mgeplf
force-pushed
the
no-reserved
branch
2 times, most recently
from
2d7f457 to
1c27928
Compare
* according to https://en.cppreference.com/w/cpp/language/identifiers * identifiers with a double underscore anywhere; * identifiers that begin with an underscore followed by an uppercase letter; * in the global namespace, identifiers that begin with an underscore. * clang w/ `-Weverything` is including `-Wreserved-id-macro`, which fails with the current macro naming scheme. * cleaned up tests a bit
Contributor
Author
|
Test appear to be failing w/ |
Contributor
Author
I tried locally, and with |
henryiii
reviewed
Nov 12, 2025
Contributor
Author
|
Great, thanks! Appreciate all you do, by the way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
according to https://en.cppreference.com/w/cpp/language/identifiers
clang w/
-Weverythingis including-Wreserved-id-macro, which fails with the current macro naming scheme.cleaned up tests a bit