Add .gitattributes to force .rst files to LF line endings #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup.py runs a regex which assumes LF line endings over the contents of CHANGELOG.rst. When installing pyopenssl from source (`pip install git+...`) on Windows, there's a good chance these files will be checked out with CRLF line endings today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.py runs a regex which assumes LF line endings
over the contents of CHANGELOG.rst.
When installing pyopenssl from source (
pip install git+...)on Windows, there's a good chance these files will be checked
out with CRLF line endings today, which leads to:
We could also address this by having the
read_filefunction in setup.py enforce LF line endings.
I think changing
codecs.opento justopenwould do it, since the default behavior of
universal newlines would be to translate to LF.