-
-
Notifications
You must be signed in to change notification settings - Fork 48
Update Hyperlint Styles #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## batson #140 +/- ##
===========================================
- Coverage 94.55% 61.70% -32.86%
===========================================
Files 12 21 +9
Lines 2040 3128 +1088
===========================================
+ Hits 1929 1930 +1
- Misses 111 1198 +1087
Continue to review full report in Codecov by Sentry.
|
CodSpeed Performance ReportMerging #140 will not alter performanceComparing Summary
|
samuelcolvin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pre-commit is complaining about a missing new line at the end of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must say I don't love this path, could we not have just one toml file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback, it's part of the rules engine right now but I'll talk it over with the team and see what we can do.
a26ac69 to
dde2b15
Compare
dde2b15 to
e3a95a8
Compare
|
replaced by #142. |
Update Hyperlint styles for #136