Repository navigation
fix(otel): upgrade OpenTelemetry and review retry defaults - #162
Open
bruno-espino wants to merge 2 commits into
Open
bruno-espino wants to merge 2 commits into
bruno-espino wants to merge 2 commits into
Conversation
Reproduce lost status codes for HTTP collector refusals and require one request per export.
Upgrade OpenTelemetry to 0.33.1 and prepare Logfire 0.14.0 so returned HTTP export errors retain status codes. Closes pydantic#161. This patch currently disables 0.33's new default of up to three retries for network failures and HTTP 429, 502, 503, and 504. Retries can recover batches after temporary refusals, as recommended by the [OTLP specification](https://opentelemetry.io/docs/specs/otlp/#retryable-response-codes). Retrying an unacknowledged batch can also duplicate delta metrics. The exposed `RetryPolicy` has no per-error switch. Should we: 1. Keep single-attempt exports or adopt the upstream default? 2. Expose a retry option? This keeps 0.13.1's default behavior. Callers that enabled `experimental-http-retry` change from up to four attempts to one, with no Logfire override. Public OpenTelemetry types change, and HTTP bodies over 64 MiB are rejected. Tracing integrations and the Axum example are updated. Verified with Linux workspace tests, focused macOS regressions, feature checks, lints, and docs.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade OpenTelemetry to 0.33.1 and prepare Logfire 0.14.0 so returned HTTP export errors retain status codes. Closes #161.
This patch currently disables 0.33's new default of up to three retries for network failures and HTTP 429, 502, 503, and 504.
Retries can recover batches after temporary refusals, as recommended by the OTLP specification. Retrying an unacknowledged batch can also duplicate delta metrics. The exposed
RetryPolicyhas no per-error switch.Should we:
This keeps 0.13.1's default behavior. Callers that enabled
experimental-http-retrychange from up to four attempts to one, with no Logfire override.Public OpenTelemetry types change, and HTTP bodies over 64 MiB are rejected. Tracing integrations and the Axum example are updated.
Verified with Linux workspace tests, focused macOS regressions, feature checks, lints, and docs.