Skip to content

Remove logfire.variables_clear since it's for tests, not users#2033

Open
alexmojaki wants to merge 2 commits into
mainfrom
alex/hide-variables-clear
Open

Remove logfire.variables_clear since it's for tests, not users#2033
alexmojaki wants to merge 2 commits into
mainfrom
alex/hide-variables-clear

Conversation

@alexmojaki

Copy link
Copy Markdown
Collaborator

No description provided.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@alexmojaki alexmojaki requested a review from dmontagu June 18, 2026 12:52
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8d616069-9b36-4790-8850-603506d83c1c

📥 Commits

Reviewing files that changed from the base of the PR and between 91f5225 and 10fc5b6.

📒 Files selected for processing (2)
  • logfire/__init__.py
  • tests/conftest.py
💤 Files with no reviewable changes (1)
  • logfire/init.py

📝 Walkthrough

Walkthrough

variables_clear is removed as a module-level alias in logfire/__init__.py and dropped from the __all__ export list, making it no longer part of the public API. The autouse config fixture in tests/conftest.py is updated to call logfire.DEFAULT_LOGFIRE_INSTANCE.variables_clear() directly, since the module-level shortcut no longer exists.

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided, which is insufficient to evaluate relevance to the changeset. Add a brief description explaining why variables_clear should be removed (e.g., it's internal test infrastructure, not part of the public API).
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing the variables_clear public export from logfire because it's test-only functionality.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch alex/hide-variables-clear

Comment @coderabbitai help to get the list of available commands and usage tips.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants