Allow custom provider factory to be passed into infer_model
#3341
+25
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Douwe Maan <[email protected]>
DouweM
changed the title
infer_model
DouweM
requested changes
Nov 6, 2025
| def infer_model( # noqa: C901 | ||
| model: Model | KnownModelName | str, provider_factory: Callable[[str], Provider[Any]] = infer_provider | ||
| ) -> Model: | ||
| """Infer the model from the name. May optionally pass a callable that setup a custom provider for the model.""" |
There was a problem hiding this comment.
I think it's worth clarifying that the factory is passed the provider name, not the model name.
There was a problem hiding this comment.
Let's use the Args:\n... format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3163 based on feedback in #3185