Add metadata support to deferred tool exceptions #3345
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables CallDeferred and ApprovalRequired exceptions to carry arbitrary metadata via an optional `metadata` parameter. The metadata is accessible in DeferredToolRequests.metadata keyed by tool_call_id. This allows tools to: - Provide cost/time estimates for approval decisions - Include task IDs for external execution tracking - Store context about why approval is required - Attach priority or urgency information Backward compatible - metadata defaults to empty dict if not provided.
Extract metadata population logic into separate _populate_deferred_calls helper function to reduce cyclomatic complexity from 16 to 15.
DouweM
requested changes
Nov 6, 2025
|
|
||
| pass | ||
| def __init__(self, metadata: dict[str, Any] | None = None): | ||
| self.metadata = metadata or {} |
There was a problem hiding this comment.
If there's no metadata, I'd rather store None, and not add the tool_call_id to DeferredToolRequests.metadata at all
DouweM
reviewed
Nov 6, 2025
| Args: | ||
| metadata: Optional dictionary of metadata to attach to the deferred tool call. | ||
| This metadata will be available in `DeferredToolRequests.metadata` keyed by `tool_call_id`. |
There was a problem hiding this comment.
You'll want to update the TemporalWrapperToolset._{un}wrap_call_tool_result methods to consider the new metadata arg as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables CallDeferred and ApprovalRequired exceptions to carry arbitrary metadata via an optional
metadataparameter. The metadata is accessible in DeferredToolRequests.metadata keyed by tool_call_id.Backward compatible - metadata defaults to empty dict if not provided.
I still need to do a proper review of this, check against existing testing conventions, and at the very least I'll be rewriting part of the docs updates, but opening as Draft for visibility and early feedback.