Make FastMCPToolset work with DBOS #3540
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The test failed because it took a long time (15min) to download dependencies. A re-run should succeed. |
DouweM
requested changes
Nov 26, 2025
| event_stream_handler: Optional event stream handler to use instead of the one set on the wrapped agent. | ||
| mcp_step_config: The base DBOS step config to use for MCP server steps. If no config is provided, use the default settings of DBOS. | ||
| model_step_config: The DBOS step config to use for model request steps. If no config is provided, use the default settings of DBOS. | ||
| fastmcp_toolset_step_config: The base DBOS step config to use for FastMCP toolset steps. If no config is provided, use the default settings of DBOS. |
Collaborator
There was a problem hiding this comment.
How would you feel about using the existing mcp_step_config?
| self._step_config = step_config or {} | ||
| self._step_name_prefix = step_name_prefix | ||
| id_suffix = f'__{wrapped.id}' if wrapped.id else '' | ||
| self._name = f'{step_name_prefix}__fastmcp_toolset{id_suffix}' |
Collaborator
There was a problem hiding this comment.
Note that in the Temporal implementation, we use the same activity names as the MCPServer. I wouldn't mind making the difference between MCPServer and FastMCPToolset here more invisible as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply similar fixes from #3413 to DBOS agent. Make sure FastMCPToolset
get_toolsandcall_toolare properly wrapped as DBOS steps. Added a test to verify they're correctly checkpointed in the database as steps.Also fixed an issue where
get_toolssometimes would raise a non-serializable exception.