Skip to content

Do not rely on np.broadcast_to to perform trivial dimension insertion #10277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 6, 2025

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Apr 30, 2025

pytest xarray/tests/test_variable.py::TestVariable::test_set_dims_without_broadcast

hmaarrfk added a commit to hmaarrfk/xarray that referenced this pull request Apr 30, 2025
@hmaarrfk hmaarrfk changed the title Broadcast to Do not rely on np.broadcast_to to perform trivial dimension insertion Apr 30, 2025
@TomNicholas
Copy link
Member

Nice - this would have probably made writing VirtualiZarr easier 😅

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented May 3, 2025

hmm, did i do something to

image

@dcherian dcherian merged commit b8e3be8 into pydata:main May 6, 2025
32 checks passed
@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented May 6, 2025

awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants