Fix: coerce unknown types to O dtype #10339
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check for Python objects that neither have numpy dtype
dtype
attributes nor are one of the builtin types so that type promotion succeeds and defaults toobject
dtype.This deals with cases where user-defined instances are in the array which would otherwise trip up
numpy.result_type
.I did think about placing this in
xarray.core.dtypes.preprocess_types
but chose to place it closest to where it causes issues (namely, on callingxp.result_type
).sum
to custom object arrays withmin_count=1
if n_dims <= sum_dims #9755whats-new.rst
api.rst