Fix reindex on Dataset from MultiIndex DataFrame with RuntimeError #10381
Conversation
|
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
xarray/tests/test_indexes.py
Outdated
| @@ -293,6 +293,35 @@ def test_reindex_like(self) -> None: | |||
| with pytest.raises(ValueError, match=r".*index has duplicate values"): | |||
| index3.reindex_like(index2) | |||
|
|
|||
| def test_reindex_pandas_multiframe(self) -> None: | |||
There was a problem hiding this comment.
A simpler test for the fixed issue would something like:
def test_reindex_with_multiindex_level(self) -> None:
# test for https://github.com/pydata/xarray/issues/10347
mindex = pd.MultiIndex.from_product([[100, 200, 300], [1, 2, 3, 4]], names=["x", "y"])
y_idx = PandasIndex(mindex.levels[1], "y")
ds1 = xr.Dataset(coords={"y": [1, 2, 3]})
ds2 = xr.Dataset(coords=xr.Coordinates.from_xindex(y_idx))
actual = ds1.reindex(y=ds2.y)
assert_identical(actual, ds2)I'd also move this test into test_dataset.py and leave test_indexes.py for testing the logic that is implemented in xarray.core.indexes.
There was a problem hiding this comment.
Thank you @benbovy for the review!
I have implemented the test as you suggested. I put the test to the end of the file, if that's not correct, let me know.
Zsolt
|
Hi @benbovy , If you have time, could you please take another look at the fix? I changed the PR based on your suggestions. Thanks for all the help, |
|
Merging... The failing test looks unrelated. |
|
Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! |
whats-new.rstapi.rst