fix: error handling decode_cf_var exceptions - use add_note #10886
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
kmuehlbauer
requested changes
Oct 31, 2025
Contributor
kmuehlbauer
left a comment
kmuehlbauer
left a comment
There was a problem hiding this comment.
Thanks @jonaslb. This is looking good. The now failing test needs fixing by adapting the match according to your changes.
You might also add an entry to whats-new.rst.
jonaslb
force-pushed
the
fix-type-error
branch
from
8ed5a7d to
a5388bf
Compare
jonaslb
force-pushed
the
fix-type-error
branch
from
550beec to
8023f9f
Compare
Contributor
Author
|
Thanks for your review, I guess I was surprised that there was already a test here, but I adapted the existing one as needed and now all should be green and ready |
kmuehlbauer
approved these changes
Oct 31, 2025
dcherian
approved these changes
Oct 31, 2025
|
Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decode_cf_variablescan lead toTypeError#10873whats-new.rstapi.rstNot sure if a test is necessary here. Let me know if you think it is.
Fix implemented according to suggestion in the issue.