Skip to content

rename truncate_energy_decay_curve#124

Merged
mberz merged 2 commits intodevelopfrom
feature/rename_truncate_edc
Feb 10, 2026
Merged

rename truncate_energy_decay_curve#124
mberz merged 2 commits intodevelopfrom
feature/rename_truncate_edc

Conversation

@f-brinkmann
Copy link
Member

@f-brinkmann f-brinkmann commented Jan 30, 2026

Which issue(s) are closed by this pull request?

Closes #122

Changes proposed in this pull request:

  • rename truncate_energy_decay_curve to threshold_energy_decay_curve
  • add/improve docstring

@f-brinkmann f-brinkmann added this to the v1.0.0 milestone Jan 30, 2026
@f-brinkmann f-brinkmann self-assigned this Jan 30, 2026
@f-brinkmann f-brinkmann added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 30, 2026
@f-brinkmann f-brinkmann moved this from Backlog to Require review in Weekly Planning Jan 30, 2026
@mberz
Copy link
Member

mberz commented Feb 6, 2026

Please rebase your branch onto the working state of develop to fix the failing test.

@f-brinkmann f-brinkmann force-pushed the feature/rename_truncate_edc branch from 56ef36d to dfc5b43 Compare February 7, 2026 14:15
Copy link
Member

@mberz mberz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation needs an update on the threshold level renaming.
This should also make ruff happy ;)

Co-authored-by: Marco Berzborn <mberz@users.noreply.github.com>
@f-brinkmann
Copy link
Member Author

The documentation needs an update on the threshold level renaming. This should also make ruff happy ;)

Thanks for catching. I was too lazy and did not check locally.

@f-brinkmann f-brinkmann requested a review from mberz February 10, 2026 11:34
@mberz mberz merged commit f3f5d8b into develop Feb 10, 2026
13 checks passed
@github-project-automation github-project-automation bot moved this from Require review to Done in Weekly Planning Feb 10, 2026
@mberz mberz deleted the feature/rename_truncate_edc branch February 10, 2026 13:01
@mberz mberz linked an issue Feb 20, 2026 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Question] Improve function naming in edc module

2 participants