Refactor the parametric energy decay curve function#74
Draft
Conversation
- uses reverbation time as input instead of geometry - returns pf.TimeData object - independent of sabine/eyring equations
ahms5
requested changes
Oct 10, 2025
Member
ahms5
left a comment
ahms5
left a comment
There was a problem hiding this comment.
why is this PR called refactor if a new method is added?
| reverberation_time : float | numpy.ndarray[float] | ||
| The reverberation time in seconds. | ||
| energy : float | numpy.ndarray[float], optional | ||
| The initial energy of the sound field, by default 1 |
Member
There was a problem hiding this comment.
Suggested change
| The initial energy of the sound field, by default 1 | |
| The initial energy of the sound field, by default 1. |
|
|
||
| Returns | ||
| ------- | ||
| pyfar.TimeData |
Member
There was a problem hiding this comment.
Suggested change
| pyfar.TimeData | |
| energy_time_curve : pyfar.TimeData |
in pyfar we usually state it like this. I see the point of redundany espacially in this case.
| Returns | ||
| ------- | ||
| pyfar.TimeData | ||
| The energy decay curve. |
Member
There was a problem hiding this comment.
hwo about return the timeData ofject of cshape broadcasted from reverberation_time and energy
github-project-automation
bot
moved this from Drafting Phase
to Require review
in Weekly Planning
Member
Author
This PR was not ready for review, yet ;) When it's ready it will replace the function |
github-project-automation
bot
moved this from Require review
to Done
in Weekly Planning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to the function