Skip to content

revise PR template on Github #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ahms5 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

revise PR template on Github #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,31 @@

Closes #

### Changes proposed in this pull request:
### Changes proposed in this pull request

-
-
-

### Checklist for a complete Pull request

- [ ] tests added/passed
- [ ] add an entry to the [changelog](../CHANGELOG.md)

Comment on lines +13 to +15
Copy link
Member Author

@ahms5 ahms5 Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the pyopensci template was just a 4 point checklist, I tried to adapt it to our previous template


<!-- ----------------------------------------------------------------
MAKE SURE YOUR PR GETS THE ATTENTION IT DESERVES!
----------------------------------------------------------------

* FORMAT IT RIGHT:
https://www.numpy.org/devdocs/dev/development_workflow.html#writing-the-commit-message

* IF IT'S A NEW FEATURE OR API CHANGE, TEST THE WATERS:
https://www.numpy.org/devdocs/dev/development_workflow.html#get-the-mailing-list-s-opinion

* HIT ALL THE GUIDELINES:
https://numpy.org/devdocs/dev/index.html#guidelines

* WHAT TO DO IF WE HAVEN'T GOTTEN BACK TO YOU:
https://www.numpy.org/devdocs/dev/development_workflow.html#getting-your-pr-reviewed
-->
Comment on lines +17 to +32
Copy link
Member Author

@ahms5 ahms5 Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is from nump, it is basically a commented markdown and will be hidden in the pr later

Loading