Update Docker command handling to avoid empty results#1352
Merged
Fizzadar merged 3 commits intopyinfra-dev:3.xfrom Jun 6, 2025
KalvadTech:fix/1278
Merged
Update Docker command handling to avoid empty results#1352Fizzadar merged 3 commits intopyinfra-dev:3.xfrom KalvadTech:fix/1278
Fizzadar merged 3 commits intopyinfra-dev:3.xfrom
KalvadTech:fix/1278
Conversation
Add test file for DockerImages fact
The original command used double quotes unnecessarily, which could cause issues with shell interpretation. This change ensures the command is correctly quoted.
Refactor Docker fact classes to use multiline string commands and update corresponding test JSON files to match the new command format.
Member
|
Note: test issue unrelated, don't have perms so can't rebase but should be ok once landed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It fix #1278