Skip to content

Add transPath to input#77

Merged
samwaseda merged 5 commits into
mainfrom
transpath
May 9, 2026
Merged

Add transPath to input#77
samwaseda merged 5 commits into
mainfrom
transpath

Conversation

@samwaseda

Copy link
Copy Markdown
Member

This pull request adds support for the transPath group to the ricTS section in the Sphinx input parser. The transPath group allows users to specify an initial guess for the atomic displacement pattern along the transition direction, which is important for transition state searches. The changes include updates to both the Python parser logic and the YAML schema.

New feature: transPath support in ricTS:

  • Added an optional transPath parameter to the _sphinx__main__ricTS function, updated its docstring, and ensured it is passed to the underlying value filler. (sphinx_parser/input.py) [1] [2] [3]
  • Implemented the _sphinx__main__ricTS__transPath helper function to handle the transPath group, including its arguments (dir_, atomId, atomIds) and documentation. (sphinx_parser/input.py)

Schema update:

  • Added the transPath group to the sphinx.main.ricTS section in the YAML schema, with fields for atomId, atomIds, and dir, along with descriptions and data types. (sphinx_parser/src/input_data.yml)

@samwaseda samwaseda requested a review from freyso May 6, 2026 11:34
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown

Binder 👈 Launch a binder notebook on branch pyiron/sphinx_parser/transpath

@codacy-production

codacy-production Bot commented May 6, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 5 duplication

Metric Results
Complexity 0
Duplication 5

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented May 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.63%. Comparing base (ef195f2) to head (134cdd7).

Files with missing lines Patch % Lines
sphinx_parser/input.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   88.70%   88.63%   -0.07%     
==========================================
  Files           8        8              
  Lines         841      845       +4     
==========================================
+ Hits          746      749       +3     
- Misses         95       96       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for the transPath group under sphinx.main.ricTS so users can provide an initial transition-direction displacement pattern for transition state searches.

Changes:

  • Extended sphinx.main.ricTS(...) to accept an optional transPath group and pass it through to the generated input dictionary.
  • Added a new sphinx.main.ricTS.transPath(...) helper for constructing the transPath group.
  • Updated the YAML schema to include ricTS.transPath with atomId / atomIds and required dir.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
sphinx_parser/src/input_data.yml Adds transPath schema under sphinx.main.ricTS (fields + descriptions).
sphinx_parser/input.py Adds transPath parameter to ricTS and introduces the ricTS.transPath group helper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sphinx_parser/src/input_data.yml Outdated
Comment thread sphinx_parser/input.py
Comment thread sphinx_parser/input.py Outdated
Comment thread sphinx_parser/input.py Outdated
samwaseda and others added 4 commits May 9, 2026 20:24
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@samwaseda samwaseda merged commit dbaa775 into main May 9, 2026
19 of 21 checks passed
@samwaseda samwaseda deleted the transpath branch May 9, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants