Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 5 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
==========================================
- Coverage 88.70% 88.63% -0.07%
==========================================
Files 8 8
Lines 841 845 +4
==========================================
+ Hits 746 749 +3
- Misses 95 96 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds support for the transPath group under sphinx.main.ricTS so users can provide an initial transition-direction displacement pattern for transition state searches.
Changes:
- Extended
sphinx.main.ricTS(...)to accept an optionaltransPathgroup and pass it through to the generated input dictionary. - Added a new
sphinx.main.ricTS.transPath(...)helper for constructing thetransPathgroup. - Updated the YAML schema to include
ricTS.transPathwithatomId/atomIdsand requireddir.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
sphinx_parser/src/input_data.yml |
Adds transPath schema under sphinx.main.ricTS (fields + descriptions). |
sphinx_parser/input.py |
Adds transPath parameter to ricTS and introduces the ricTS.transPath group helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This pull request adds support for the
transPathgroup to thericTSsection in the Sphinx input parser. ThetransPathgroup allows users to specify an initial guess for the atomic displacement pattern along the transition direction, which is important for transition state searches. The changes include updates to both the Python parser logic and the YAML schema.New feature:
transPathsupport inricTS:transPathparameter to the_sphinx__main__ricTSfunction, updated its docstring, and ensured it is passed to the underlying value filler. (sphinx_parser/input.py) [1] [2] [3]_sphinx__main__ricTS__transPathhelper function to handle thetransPathgroup, including its arguments (dir_,atomId,atomIds) and documentation. (sphinx_parser/input.py)Schema update:
transPathgroup to thesphinx.main.ricTSsection in the YAML schema, with fields foratomId,atomIds, anddir, along with descriptions and data types. (sphinx_parser/src/input_data.yml)