allow JSONService to return request objects#830
Open
mungerd wants to merge 1 commit intopyjs:masterfrom
Open
Conversation
JSONService.sendRequest and JSONService.sendNotify used to return a request ID and an integer, respectively. This patch adds a `return_object' flag to the JSONService, ServiceProxy and JSONProxy constructors. When ̀`return_object' is True, JSONService.sendRequest and JSONService.sendNotify will append the request object to their return value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSONService.sendRequest and JSONService.sendNotify used to return a request ID
and an integer, respectively.
This patch adds a
return_object' flag to the JSONService, ServiceProxy and JSONProxy constructors. When ̀return_object' is True, JSONService.sendRequestand JSONService.sendNotify will append the request object to their return
value.
This allows to access the JavaScript XMLHttpRequest object, on which the abort() method can be called in order to interrupt a very long request.
Resolves #796
Should be backward compatible with existing code.