-
Notifications
You must be signed in to change notification settings - Fork 8
PylonTickableEntity #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Intybyte
wants to merge
6
commits into
master
Choose a base branch
from
vaan/api/tickable-entities
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
PylonTickableEntity #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seggan
reviewed
Nov 17, 2025
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/entity/base/PylonTickableEntity.kt
Outdated
Show resolved
Hide resolved
Seggan
approved these changes
Nov 18, 2025
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/entity/base/PylonTickableEntity.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Seggan <[email protected]>
LordIdra
requested changes
Nov 18, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a few things missing here - I would suggest including the following in this PR, but if you don't want to do them in this PR just make sure open issues for them so we can keep track:
- Needs async ticking option as we have for blocks
- Needs error handling (we have error handling set up for other entity interfaces)
- Currently you're using a getter for
tickDelay, but the convention with these sorts of interface variables is to usesetTickIntervalandsetAsyncand so on. The reason for this is to avoid having loads of getters for trivial properties which became quite a problem especially w/ the fluid stuff. It should hopefully be fairly straightforward as you can replicate what ticking blocks do.
(also docs :P - you can just do something similar to the block tickers for this)
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/entity/base/PylonTickableEntity.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #456