Skip to content

CartographyTable fix #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2025
Merged

CartographyTable fix #497

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd9bedf
CartographyTable fix
Intybyte Nov 21, 2025
038d7c6
Comment was addressed
Intybyte Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/recipe/RecipeListener.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import io.github.pylonmc.pylon.core.recipe.vanilla.VanillaRecipeType
import io.github.pylonmc.pylon.core.util.isPylonAndIsNot
import io.github.pylonmc.pylon.core.util.isPylonSimilar
import io.papermc.paper.datacomponent.DataComponentTypes
import io.papermc.paper.event.player.CartographyItemEvent
import org.bukkit.Keyed
import org.bukkit.block.Crafter
import org.bukkit.block.Furnace
Expand Down Expand Up @@ -82,6 +83,16 @@ internal object PylonRecipeListener : Listener {
}
}

@EventHandler(priority = EventPriority.LOWEST)
private fun onCartography(e: CartographyItemEvent) {
val inventory = e.inventory
val hasPylonItems = inventory.any { it.isPylonAndIsNot<VanillaCraftingItem>() }
Copy link
Contributor

@LordIdra LordIdra Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could have a VanillaCartographyItem but I think this is fine, and niche enough that it wouldn't be used


if (hasPylonItems) {
inventory.result = null
}
}

@EventHandler(priority = EventPriority.LOWEST)
private fun onCrafterCraft(e: CrafterCraftEvent) {
val crafterState = e.block.state as? Crafter ?: return
Expand Down