Skip to content

Remove custom logsumexp #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

fonnesbeck
Copy link
Member

@fonnesbeck fonnesbeck commented Feb 20, 2025

Ch. 17 incorrectly states that PyTensor uses a "vanilla" logsumexp that is unstable. This removes that code and uses PyTensor functions.

Helpful links


📚 Documentation preview 📚: https://pymc-examples--778.org.readthedocs.build/en/778/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@aloctavodia aloctavodia merged commit ccef86c into pymc-devs:main Feb 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants