-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Consolidate progress bar speed logic #7801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate progress bar speed logic #7801
Conversation
what's up with the mypy. That is working locally for me. Maybe I need to update my versions |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7801 +/- ##
==========================================
+ Coverage 92.84% 92.87% +0.02%
==========================================
Files 107 107
Lines 18380 18373 -7
==========================================
- Hits 17065 17064 -1
+ Misses 1315 1309 -6
🚀 New features to boost your workflow:
|
It's new numpy type hints stuff, I was putting some ignores in my PR to bump PyTensor that's still open |
Alright. Let me know if I need to adjust anything in this PR... |
Ping |
Thanks @williambdean |
Description
Remove the duplicated logic for calculating speed and unit
Related Issue
compute_draw_speed
#7798Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7801.org.readthedocs.build/en/7801/