-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix broken import of sp_sum #7984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sp_sum has been moved in pytensor from pytensor.sparse.basic to pytensor.sparse.math The higher level module pytensor.sparse exports this function.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7984 +/- ##
=======================================
Coverage 91.49% 91.49%
=======================================
Files 116 116
Lines 18963 18964 +1
=======================================
+ Hits 17350 17351 +1
Misses 1613 1613
🚀 New features to boost your workflow:
|
|
Didn't notice the open PR, I left a comment on the original issue. PyMC main should be compatible with the pinned PyTensor dependency not its main branch. We'll be doing a new PyTensor release soon and follow with update on the PyMC side |
|
@ricardoV94 I was trying the new version of Pytensor today and ran into the same issue. `--------------------------------------------------------------------------- File ~/Documents/data_science/pixi_environments/pymc_dev_20251217/.pixi/envs/default/lib/python3.13/site-packages/pymc/init.py:50 File ~/Documents/data_science/pixi_environments/pymc_dev_20251217/.pixi/envs/default/lib/python3.13/site-packages/pymc/sampling/init.py:18 File ~/Documents/data_science/pixi_environments/pymc_dev_20251217/.pixi/envs/default/lib/python3.13/site-packages/pymc/sampling/forward.py:55 File ~/Documents/data_science/pixi_environments/pymc_dev_20251217/.pixi/envs/default/lib/python3.13/site-packages/pymc/distributions/init.py:88 File ~/Documents/data_science/pixi_environments/pymc_dev_20251217/.pixi/envs/default/lib/python3.13/site-packages/pymc/distributions/multivariate.py:28 ImportError: cannot import name 'sp_sum' from 'pytensor.sparse.basic' (/Users/zweli/Documents/data_science/pixi_environments/pymc_dev_20251217/.pixi/envs/default/lib/python3.13/site-packages/pytensor/sparse/basic.py)` |
|
We've released the new PyTensor with this breaking change so it's finally time to sync PyMC with it. We need to bump the dependency and see if the CI passes. More things may have broken |
|
Closing in favor of #8010 Thanks for spotting the change. Added you as co-author |
|
I'll need your github email (can be the noreplies one) to add you as a co-author |
zwelitunyiswa [email protected] |
sp_sum has been moved in pytensor from pytensor.sparse.basic to pytensor.sparse.math
The higher level module pytensor.sparse exports this function.
Description
Related Issue
Checklist
Type of change