Don't run the PyPi job all the time#1363
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1363 +/- ##
=======================================
Coverage 82.04% 82.04%
=======================================
Files 231 231
Lines 52364 52364
Branches 9217 9217
=======================================
Hits 42962 42962
Misses 7094 7094
Partials 2308 2308 🚀 New features to boost your workflow:
|
lucianopaz
left a comment
lucianopaz
left a comment
There was a problem hiding this comment.
It looks to me like there's potential to group the whole condition of the if job runs into an output of the check_changes job. I'm not sure how to do that though. Maybe Claude knows. I've added a suggestion on to kind of hint at what I mean.
|
Would either of you @lucianopaz or @maresb be willing to take the PR over the finish line? |
I'm overwhelmed at the moment. You can try pinging me again in a few weeks |
|
I can take over next week |
Super |
|
Looks like the |
lucianopaz
force-pushed
the
pypi-job
branch
2 times, most recently
from
b4b1f4c to
fe6b484
Compare
|
It's fixed now @maresb, @ricardoV94. Let me know if you think it's ok. |
|
@lucianopaz you can rebase for the tests to pass |
|
@maresb do you want to take another look? |
Co-authored-by: Ben Mares <services-git-throwaway2@tensorial.com>
|
This should have been squashed merged |
4 participants
This was mostly Claude-generated changes, so appreciate careful review.
Trying to save tons of compute time we wast building the cython-scan extension on the ubuntu wheel for every PR and push to main. Closes #219
📚 Documentation preview 📚: https://pytensor--1363.org.readthedocs.build/en/1363/