Exclude numba rewrites from JAX Scan rewrites#1825
Merged
ricardoV94 merged 1 commit intopymc-devs:mainfrom Jan 5, 2026
Merged
Conversation
ricardoV94
commented
Jan 5, 2026
| # Optimize inner graph (exclude any defalut rewrites that are incompatible with JAX mode) | ||
| rewriter = ( | ||
| get_mode(op.mode).including("jax").excluding(*JAX._optimizer.exclude).optimizer | ||
| get_mode(op.mode) |
Member
Author
There was a problem hiding this comment.
Specifically when op.mode is None, it will return a NumbaLinker if pytensor.config.linker="numba" or pytensor.config.mode="NUMBA".
ricardoV94
requested review from
jessegrabowski
and removed request for
jessegrabowski
jessegrabowski
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the default mode can be Numba, we could get numba-specific rewrites (which are never the default otherwise) in the JAX scan optimization.
This is a symptom of Scan having the mode concept, which we should move away from. For now the band-aid is simple enough.
Led to failures in pymc-devs/pymc-extras#615