Skip to content

Fix scan_checkpoints with sequences #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented May 7, 2024

Description

Found this by accident while working with Join and trying to understand the view flag (see #753)

This was completely broken for sequences, but the fix is simple enough, so I took a stab at it.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@ricardoV94 ricardoV94 added bug Something isn't working scan labels May 7, 2024
@ricardoV94 ricardoV94 requested a review from jessegrabowski May 7, 2024 14:16
@ricardoV94 ricardoV94 force-pushed the fix_scan_checkpoint_with_sequences branch from b6ab71b to e5ff90e Compare May 7, 2024 16:37
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.81%. Comparing base (b8e26cd) to head (e5ff90e).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #754   +/-   ##
=======================================
  Coverage   80.81%   80.81%           
=======================================
  Files         162      162           
  Lines       46808    46817    +9     
  Branches    11452    11453    +1     
=======================================
+ Hits        37826    37835    +9     
+ Misses       6734     6733    -1     
- Partials     2248     2249    +1     
Files Coverage Δ
pytensor/scan/checkpoints.py 76.47% <100.00%> (+5.04%) ⬆️

... and 1 file with indirect coverage changes

@ricardoV94 ricardoV94 merged commit 5a61625 into pymc-devs:main May 11, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working scan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants