-
Notifications
You must be signed in to change notification settings - Fork 149
Run whole test suite on numba backend #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
2eb7fe7 to
1f093cd
Compare
|
Locally I ran all the tests in Numba caching is baaaaaaaaaaaaaaaaaaaaaaaaaaaaaaad |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
5c4491d to
a1e3775
Compare
This comment was marked as outdated.
This comment was marked as outdated.
6f6e8bb to
53d9a26
Compare
53d9a26 to
9076c99
Compare
9076c99 to
0af7cb7
Compare
|
After caching the test file now runs in 50s after caching vs 6s before the PR, so only 8x slower now :( |
0af7cb7 to
17ef6a4
Compare
bd3da41 to
5f17484
Compare
463cba4 to
3367ea8
Compare
Also fix infinity identities for unsigned integers
…) advanced indexing When default `ignore_updates=True` for inc_subtensor, and boolean indices were rewritten during specialize
Also need to re-filter warnings because pytestmark.filterwarnings overrides library filters
Mark overly specific tests as xfail
* Allow linker to change at runtime, and affect both `Mode` and `FAST_RUN` modes * Remove float32 parametrization from test suite. Tests that care about this should cover it explicitly
e928b3e to
e46f409
Compare
|
The tests are passing with all 3 modes: Numba, C and FAST_COMPILE. I removed the floatX parametrization. It's a common source of wasted resources / contributor.confusion (assert_allclose, and test values failures) and I don't think it gives much in return. Better for tests to be conscious and try explicitly when relevant |
What is broken / not supported by Numba:
The plan now
Immediate action