Fix Py_XDECREF #172
Open
Fix Py_XDECREF #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the changes in #164, listing
Py_XDECREFas an allowed symbol is no longer necessary.Py_XDECREFisstatic inlineand if a symbol is produced (depending on C compiler optimization), it is a local symbol.With this PR, the current list of allowed symbols becomes empty. I was not sure whether to remove it or keep it in case it is needed in the future. I sided for the second option and added a test (using some monkeypatching, hope that's OK). If you guys feel otherwise, then I can drop the last commit and push a new one removing the
_ALLOWED_SYMBOLSlist.cc @isuruf for viz as the author of #164