-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General docs improvements for v3.0 #2280
base: main
Are you sure you want to change the base?
Conversation
We don't have to swap the envvar / TOML config in this PR, it can be a followup, but it is on the planned items for 3.0. Also, I know I was considering making |
I can work on the toml/envvar swap once this is done. |
Okay, I'll try to tie up these changes soon.
You mean a file that's auto-detected at the project root? Personally I'm not a fan of extra project root files but I can see that some might prefer it. But, I do like the shorthand of "pyproject.toml" in tab labels and such. Diluting that to "TOML" might make it less friendly to new users. |
# Conflicts: # docs/options.md # mkdocs.yml
This should be ready for a review. I've made quite a few changes, mostly to organisation, but where I inevitably spot things that are inaccurate or out-of-date I've fixed them too, so there's quite a bit in this diff. Probably the easiest thing is to view the rendered version. ![]() Big things:
|
@@ -6,88 +6,6 @@ title: Tips and tricks | |||
|
|||
## Tips | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This info moved to platforms.md.
```yaml | ||
env: | ||
CIBW_TEST_REQUIRES: pytest | ||
CIBW_TEST_COMMAND: "pytest {project}/tests" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update the for 3.0, now that {project}/
isn't needed, but test-sources might be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good idea on removing {project}. I think we don't need TEST_SOURCES though? It's more of a thing that can be discovered as/when it's needed?
Co-authored-by: Henry Schreiner <[email protected]>
I think a bit of organisation / rethinking is due. The main change I've made here so far is to the navigation - it now looks like this:

I decided to go for the tree-based approach because it deals better with many sections/pages.
We can make the change to pyproject.toml-style configuration in this PR too, if you like @henryiii .