Experiment with --no-strip-markers with uv pip compile#2847
Draft
agriyakhetarpal wants to merge 5 commits into
Draft
Experiment with --no-strip-markers with uv pip compile#2847agriyakhetarpal wants to merge 5 commits into
--no-strip-markers with uv pip compile#2847agriyakhetarpal wants to merge 5 commits into
Conversation
Contributor
|
Oh, good find! Although it looks to me that it isn't working right- it's only including one pip version rather than both with different markers. |
henryiii
reviewed
May 13, 2026
henryiii
reviewed
May 13, 2026
| @@ -1,4 +1,5 @@ | |||
| pip | |||
| pip>=26.1.1; (implementation_name != "graalpy" or platform_system != "Windows") and python_version >= "3.10" | |||
Contributor
There was a problem hiding this comment.
Suggested change
| pip>=26.1.1; (implementation_name != "graalpy" or platform_system != "Windows") and python_version >= "3.10" | |
| pip>=26.1.1; (implementation_name != "graalpy" or platform_system != "Windows") and python_version >= "3.10" and python_version < "3.13" |
Contributor
There was a problem hiding this comment.
This doesn't quite work, because the ones that don't match don't get put into the constraints file.
Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
Contributor
|
Might be worth a report to |
Member
Author
|
Yup, I'll spend some time writing a bug report later today! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if we like this or not, but maybe it's worth looking into. cc: @joerick, following on from #2845.