-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add "python setup.py --version" replacement command #1415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a2283a1
to
523f80a
Compare
I am not convinced we need to add this. I believe it was essential to write about With things like Maybe we could list those ( |
I don't want to argue on whether it is “essential”, but does it hurt? The setuptools maintainers have been quite clear that all usage of And, yes, there is no standardized general replacement. However, it's easy and obvious to grep |
I thought merely having setuptools-scm installed had side effects, but looking at the documentation it seems like it doesn't. It has to be listed in build dependencies and there has to be a setuptools-scm table in |
setuptools-scm will be autodetected and used by setuptools when installed (like all setuptools plugins, which are discovered through entry points), but it will not change your build if you have not configured it in pyproject.toml. |
I am thinking this should be a "suggestion" rather than a recommendation. I am thinking maybe we could add a whole new subsection of suggestions (soft recommendations), something along the lines of:
What do you think? Would that work for you? This is more or less what is at the bottom of Paul's article: https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html#summary I do not want the guide to be seen as recommending specific tools unless they are the absolute obvious choice (such as build). Maybe twine could be one of those, I guess it is recommended in some other places in this guide. But for setuptools-scm (and pytest) I am a bit more reluctant, first there are other alternatives, and second the whole question about version strings is its own (hotly debated) topic. |
Well. I didn't write “a replacement for |
Yes but this table is for "hard" recommendations, as the header of the right-hand column says: "Recommendation". That is why I suggest moving this to another location outside of this recommendation table. |
Sorry, going to close this; I started updating it but trying to organize the thing well was starting to take me more time than I had to spend on this. |
Sorry for being picky about this. But this motivated me to open my own pull request on this. So effort is not lost. :) |
Add alternative solutions for more commands. GitHub: relates to pypa#1415
Add alternative solutions for more commands. GitHub: relates to pypa#1415
Add alternative solutions for more commands. GitHub: relates to pypa#1415
https://discuss.python.org/t/replacement-for-setup-py-version
📚 Documentation preview 📚: https://python-packaging-user-guide--1415.org.readthedocs.build/en/1415/