perf: add __slots__ to Specifiers #1002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
henryiii/perf/slots2
branch
from
6c0273e to
965ff1e
Compare
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/perf/slots2
branch
from
965ff1e to
1886501
Compare
notatallshaw
approved these changes
Nov 28, 2025
henryiii
added a commit
to henryiii/packaging
that referenced
this pull request
Nov 28, 2025
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
added a commit
to henryiii/packaging
that referenced
this pull request
Nov 28, 2025
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
added a commit
to henryiii/packaging
that referenced
this pull request
Nov 28, 2025
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
added a commit
to henryiii/packaging
that referenced
this pull request
Nov 30, 2025
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
added a commit
that referenced
this pull request
Nov 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
__slots__toSpecifier*. Not as important for performance as Version was, since this isn't created as often as Version is, but still a good idea, I think.