-
Notifications
You must be signed in to change notification settings - Fork 489
feat: add --with option to "pipx run" command #1666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
874e61f
to
3b43fcc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
3b43fcc
to
06877f4
Compare
Thanks a lot for running the tests! I'm a bit confused about the macos failure though (https://github.com/pypa/pipx/actions/runs/17588256767/job/50365801078?pr=1666). It seems related to the code here, but I fail to see why it fails there. Any tips you might be able to have? |
It's not related to your code here, it also failed in every other PRs. Don't worry! :D |
4eaf8b3
to
5ede3ca
Compare
CI green 🥳 |
5ede3ca
to
9153969
Compare
changelog.d/
(if the patch affects the end users)Summary of changes
Added the option in argparse for
pipx run
, and usedinject_dep
Test plan
I've used test-driven development, and there is a test for a simple case that should prove this feature is working
TODOs:
_download_and_run
to just download, so that we can inject the dependency also in the cases where theif venv.has_app == True
branch inrun_package
Closes #1607