fix: don't warn about tool.setuptools.dynamic.version when only using file finder #1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file finder When setuptools-scm is used only for its file finder functionality (no version inference), it's valid to use tool.setuptools.dynamic.version for versioning. The warning should only be issued when setuptools-scm is actually performing version inference. Changes: - Modified pyproject_reading.py to only warn when should_infer() is True - Added test for file-finder-only case (no warning expected) - Updated existing test with clarifying documentation Fixes pypa#1231
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setuptools-scm is used only for its file finder functionality
(no version inference), it's valid to use tool.setuptools.dynamic.version
for versioning. The warning should only be issued when setuptools-scm
is actually performing version inference.
Changes:
Fixes #1231