setuptools.msvc: Fix EnvironmentInfo MSBuild property with VS2017+ - #5276
Open
swt2c wants to merge 1 commit into
Open
setuptools.msvc: Fix EnvironmentInfo MSBuild property with VS2017+#5276swt2c wants to merge 1 commit into
swt2c wants to merge 1 commit into
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Microsoft changed the location of the MSBuild executable in newer Visual Studio versions. First, correct the VSInstallDir by checking known_vs_paths which is already done in other places. Then, use the "Current" directory scheme used on VS2019+. Lastly, move MSBuild before FxTools as the FxTools directory contains an outdated version of MSBuild. Fixes: pypa#5275
swt2c
force-pushed
the
fix_msbuild_newer_vs
branch
from
July 19, 2026 01:53
1fd3ed4 to
52a30da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Microsoft changed the location of the MSBuild executable in newer Visual Studio versions. First, correct the VSInstallDir by checking known_vs_paths which is already done in other places. Then, use the "Current" directory scheme used on VS2019+. Lastly, move MSBuild before FxTools as the FxTools directory contains an outdated version of MSBuild.
Closes #5275
Pull Request Checklist
newsfragments/.(See documentation for details)