Skip abi3 tests when freethreading Python build is used #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip the tests using abi3 extension when the freethreading build is used, as Python 3.13 freethreading does not support the limited API and its use results in a build error. Fixes pypa#636
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #637 +/- ##
=======================================
Coverage 71.11% 71.11%
=======================================
Files 14 14
Lines 1087 1087
=======================================
Hits 773 773
Misses 314 314 ☔ View full report in Codecov by Sentry. |
agronholm
reviewed
Oct 11, 2024
|
Thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip the tests using abi3 extension when the freethreading build is used, as Python 3.13 freethreading does not support the limited API and its use results in a build error.
Fixes #636