docs: self-managed GitLab instances are not supported (for Trusted Publishing) #15840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facutuesca
changed the title
woodruffw
reviewed
Apr 23, 2024
| @@ -106,6 +106,11 @@ each. | |||
|
|
|||
| === "GitLab CI/CD" | |||
|
|
|||
| !!! note | |||
|
|
|||
| Currently, only projects hosted on https://gitlab.com are supported. Self-managed | |||
There was a problem hiding this comment.
Nitpick for linkification (similar for other additions below):
Suggested change
| Currently, only projects hosted on https://gitlab.com are supported. Self-managed | |
| Currently, only projects hosted on <https://gitlab.com> are supported. Self-managed |
woodruffw
reviewed
Apr 23, 2024
Comment on lines
382
to
386
| !!! note | ||
|
|
||
| Currently, only projects hosted on https://gitlab.com are supported. Self-managed | ||
| instances are not supported. | ||
|
|
There was a problem hiding this comment.
No strong opinion, but IMO we could drop this one to reduce duplication: the note is already showing on both of the creation flows, so we don't need it on the use flow 🙂
facutuesca
force-pushed
the
gitlab-self-managed-docs
branch
from
ba3bb3b to
071c76f
Compare
facutuesca
force-pushed
the
gitlab-self-managed-docs
branch
from
071c76f to
004fee5
Compare
woodruffw
approved these changes
Apr 24, 2024
di
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by di/id#216, the docs don't make explicit that Trusted Publishing with GitLab only works when using the official
gitlab.cominstance, and doesn't work with self-managed instances.This changes the docs to clarify that. It also adds a section in the troubleshooting doc to identify the cause of the error generated by using a self-managed instance.
cc @di @woodruffw