Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: extract validator from inline #16701

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: extract validator from inline #16701

wants to merge 2 commits into from

Conversation

miketheman
Copy link
Member

This allows us to prevent null bytes prior to checking the DB records.

Follows similar refactor in #16599

Signed-off-by: Mike Fiedler [email protected]

@miketheman
refactor: extract validator from inline
3eb8236 
This allows us to prevent null bytes prior to checking the DB records.

Follows similar refactor in pypi#16599

Signed-off-by: Mike Fiedler <[email protected]>
@miketheman
make translations
c25b6d3 
Signed-off-by: Mike Fiedler <[email protected]>
@miketheman miketheman requested a review from a team as a code owner September 12, 2024 21:13
di
di approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add a comment somewhere explaining why we're doing it this way for historical context? Or add a test that would prevent a regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@di di di approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miketheman @di