Skip to content

chore(deps): update Python version to 3.13.11 #19188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miketheman merged 4 commits into from
Jan 6, 2026
Merged

chore(deps): update Python version to 3.13.11 #19188

miketheman merged 4 commits into from
Jan 6, 2026
+15 −29

Conversation

@miketheman
Copy link
Member

@miketheman miketheman commented Dec 17, 2025

No description provided.

@miketheman miketheman added testing Test infrastructure and individual tests dependencies Pull requests that update a dependency file labels Dec 17, 2025
@sethmlarson
Copy link
Contributor

sethmlarson commented Dec 17, 2025

So the "failure" here is that prior to 3.13.11 (specifically python/cpython@333d4a6) CPython didn't understand ZIP64 EOCD extensible data at all. Now it does, so the zipfile module can actually process these ZIP archives now. But this feature isn't useful for Python packages so I'm inclined to still reject archives with ZIP64 EOCD extensible data explicitly.

@miketheman
Copy link
Member Author

miketheman commented Dec 23, 2025

But this feature isn't useful for Python packages so I'm inclined to still reject archives with ZIP64 EOCD extensible data explicitly.

Thanks for boiling it down - I agree, we should definitely reject "exotic" distributions if they don't conform to how we expect them to behave.

@miketheman miketheman force-pushed the miketheman/python-3.13.11 branch from 99bf02f to cf01cf7 Compare January 6, 2026 20:55
sethmlarson
sethmlarson approved these changes Jan 6, 2026
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the zipfile module should now handle the ZIP64 locator record properly, hence the reduction in coverage.

@miketheman miketheman marked this pull request as ready for review January 6, 2026 21:20
@miketheman miketheman requested a review from a team as a code owner January 6, 2026 21:20
@miketheman miketheman merged commit 15573a8 into pypi:main Jan 6, 2026
21 checks passed
@miketheman miketheman deleted the miketheman/python-3.13.11 branch January 6, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@di di di approved these changes

+1 more reviewer

@sethmlarson sethmlarson sethmlarson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file testing Test infrastructure and individual tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miketheman @sethmlarson @di