feat: Add IP address banning and unbanning functionality #19213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
di
force-pushed
the
feat/ban-unban-ip-address
branch
from
ce54162 to
9e10473
Compare
miketheman
added
the
admin
miketheman
approved these changes
Dec 22, 2025
Member
miketheman
left a comment
miketheman
left a comment
There was a problem hiding this comment.
LGTM - a couple of non-blocking inline comments
| assert ip_address.ban_date is not None | ||
|
|
||
|
|
||
| class TestUnbanIpAddress: |
Member
There was a problem hiding this comment.
question: worth adding a test case and handling for unbanning an already-unbanned entry, or are we fine with doing the unban operation regardless of current state?
|
|
||
| <dt class="col-sm-4">Ban Reason:</dt> | ||
| <dd class="col-sm-8">{{ ip_address.ban_reason.value }}</dd> | ||
| <dd class="col-sm-8">{{ ip_address.ban_reason.value if ip_address.ban_reason is not none else 'None' }}</dd> |
Member
There was a problem hiding this comment.
I was reading more about Jinja2 filters recently, and I think this could also be expressed as:
Suggested change
| <dd class="col-sm-8">{{ ip_address.ban_reason.value if ip_address.ban_reason is not none else 'None' }}</dd> | |
| <dd class="col-sm-8">{{ ip_address.ban_reason.value | default('None') }}</dd> |
but that means that the .value call would have failed a lookup on None.
Maybe we should instead change the BanReason from an Enum to a StrEnum, like we do in other places, and thus don't need to refer to it by .value?
A larger refactor, but probably worthwhile to consider as a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.