Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mpv): use single instance of mpv #638

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

citosid
Copy link

@citosid citosid commented Feb 1, 2023

This commit configures mpv to create an ipc-server and re-use it to playback the files so no new instances are created

Issue #637

This commit configures mpv to create an ipc-server and re-use it to playback the files so no
new instances are created

Issue pystardust#637
@Euro20179
Copy link
Collaborator

Euro20179 commented Feb 1, 2023

pidof is not posix, however if written as an addon, it doesn't matter, just check if it's installed.

There is one problem that may occur where if there is more than 1 mpv instance open it could pick the wrong one.

for this line of code

echo "{"command":["loadfile","${@}", "replace"]}"

I would use $* instead of ${@} because ${@} might act weirdly with word splitting and stuff.

Lastly, could you use the development branch instead of the master branch

Other than that it looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants