Update to lxml 3.6.0 #1215
Open
Update to lxml 3.6.0 #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add refcounting annotation that make test_long pass
Some minor fixing which found in numpy tests
Conflicts: src/runtime/float.cpp
Fix test_math refcounting error
- mark a few more things as reffail - disable "force-llvm" tests for now since a lot of those are failing - fix a couple misc issues - turn off the gcc build for now (compilation error) - turn off the release build for now (lots of tests fail in debug mode but pass in release, and I don't want to bother annotating that)
Turn on CI for the refcounting branch again
Misc refcounting leaks encountered while fixing the generator abandonment tests
To silence results for passing tests. We have a lot of tests and most of them are passing and are crowding out the failing ones. Also, turn it on when testing on travis-ci
we need this map to know which object refcounter we have to decrement in case an exception gets throwen inside an IC or the bjit. in addition fix all bjit related problems
Need a 'refUsed()' function like we have in the llvm jit, for when we pass args through an args array.
A kind-of hacky way of identifying places that do unsafe (for refcounting) setattrs. When calling RewriterVar::setattr() with an owned reference, you need to either promise to call refUsed() or refConsumed() afterwards.
They might be ok if we allowed allocating callee-save registers, but since we don't, they mean we are asking the unwinder to restore a clobbered register. This was happening in some places where we didn't call setupCall() before calling a function. This was previously ok since those cases would always throw an exception and nothing would want the values of the then-clobbered registers.
Our convention is that on deopt, the callee is responsible for calling deinitFrame(). This is tricky, since for OSR our convention is the opposite, that the caller calls deinitFrame(). This means that if we OSR and then deopt(), the top and bottom frames both think they should call deinitFrame() (since one is the caller of an OSR and the other is the callee of a deopt). This commit fixes + extends the "disable deinitFrame for this frame" approach we kind of had. For performance, deinitFrame() stays the same, but any site that might have its deinitFrame disabled (namely, in the interpreter), it should call deinitFrameMaybe() instead.
Also fix the is_live handling and make the get and set cases look more similar to each other.
I think I don't quite understand the existing optimization so just turn my new one off for now.
Cherry-pick some tester improvements from the refcounting branch
…g keys with same hashes we have to insert the elements in reverse in order to replicate cpythons behaviour. cpython is pushing the temps on it's value stack and than inserting them ona after another by poping them from the stack
fix set.add() for existing keys and fix set ast node when encountering keys with same hashes
- I think I've finally convinced myself that a refConsumed() annotation automatically includes a refUsed annotation as well. Or rather, that if you call refConsumed, the refcounter won't try to add a decref anyway. - emitCallWithAllocatedArgs already does the equivalent of refUsed() on its `additional_uses` argument.
|
lgtm, though was the second commit supposed to be part of #1223? |
Bump version numbers
update list of failing cpython tests
exec, input: if globals has no __builtins__ add it as a dictwrapper
since we were installing it from the LLVM APT repo, which they took down since it was getting too expensive. I guess we can just run with the gcc build until that situation gets resolved.
Fix std::move error on temporary object
Somehow this PR is taking longer to build, I assume from somehow missing the build cache. Assuming that it's a caching issue, bump up the time to satisfy un-cached builds. If build times continue to increase we will run into this problem again (can only regenerate the cache with a successful build but a successful build needs the cache), but this will let us defer it a bit longer :) Travis-CI builds are max 120 minutes.
Temporarily disable the clang build on travis-CI
also fix a build error when ICs are disabled
also add a option to pass MAP_32BIT to mmap
this also workarounds the problem we were having on ubuntu 16.04 where we have to use std::isinf instead of isinf()
float.cpp: now that we have float.c use some of the functions directly
major bjit improvements
kmod
force-pushed
the
master
branch
2 times, most recently
from
352fd89
to
6488a3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.