Skip to content

pytest v9.0.0 #1281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

pytest v9.0.0 #1281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,13 @@ maintainers = [
authors = [
{ name = "Tin Tvrtković", email = "[email protected]" },
]
requires-python = ">=3.9"
requires-python = ">=3.10"
classifiers = [
"Development Status :: 5 - Production/Stable",
"Framework :: AsyncIO",
"Framework :: Pytest",
"Intended Audience :: Developers",
"Programming Language :: Python :: 3 :: Only",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
Expand All @@ -42,7 +41,7 @@ dynamic = [

dependencies = [
"backports-asyncio-runner>=1.1,<2; python_version<'3.11'",
"pytest>=8.2,<9",
"pytest>=9.0.0,<10.0.0",
"typing-extensions>=4.12; python_version<'3.13'",
]
optional-dependencies.docs = [
Expand Down
55 changes: 25 additions & 30 deletions pytest_asyncio/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from collections.abc import (
AsyncIterator,
Awaitable,
Callable,
Generator,
Iterable,
Iterator,
Expand All @@ -24,10 +25,9 @@
from types import AsyncGeneratorType, CoroutineType
from typing import (
Any,
Callable,
Literal,
ParamSpec,
TypeVar,
Union,
overload,
)

Expand All @@ -49,11 +49,6 @@
PytestPluginManager,
)

if sys.version_info >= (3, 10):
from typing import ParamSpec
else:
from typing_extensions import ParamSpec

if sys.version_info >= (3, 11):
from asyncio import Runner
else:
Expand All @@ -65,7 +60,7 @@
from typing_extensions import TypeIs

_ScopeName = Literal["session", "package", "module", "class", "function"]
_R = TypeVar("_R", bound=Union[Awaitable[Any], AsyncIterator[Any]])
_R = TypeVar("_R", bound=Awaitable[Any] | AsyncIterator[Any])
_P = ParamSpec("_P")
FixtureFunction = Callable[_P, _R]

Expand Down Expand Up @@ -209,7 +204,7 @@ def _get_asyncio_mode(config: Config) -> Mode:
except ValueError as e:
modes = ", ".join(m.value for m in Mode)
raise pytest.UsageError(
f"{val!r} is not a valid asyncio_mode. Valid modes: {modes}."
f"{val!r} is not a valid asyncio_mode. Valid modes: {modes}.",
) from e


Expand Down Expand Up @@ -241,7 +236,7 @@ def _validate_scope(scope: str | None, option_name: str) -> None:
if scope not in valid_scopes:
raise pytest.UsageError(
f"{scope!r} is not a valid {option_name}. "
f"Valid scopes are: {', '.join(valid_scopes)}."
f"Valid scopes are: {', '.join(valid_scopes)}.",
)


Expand Down Expand Up @@ -280,7 +275,7 @@ def pytest_report_header(config: Config) -> list[str]:


def _fixture_synchronizer(
fixturedef: FixtureDef, runner: Runner, request: FixtureRequest
fixturedef: FixtureDef, runner: Runner, request: FixtureRequest,
) -> Callable:
"""Returns a synchronous function evaluating the specified fixture."""
fixture_function = resolve_fixture_function(fixturedef, request)
Expand All @@ -298,7 +293,7 @@ def _fixture_synchronizer(

def _wrap_asyncgen_fixture(
fixture_function: Callable[
AsyncGenFixtureParams, AsyncGeneratorType[AsyncGenFixtureYieldType, Any]
AsyncGenFixtureParams, AsyncGeneratorType[AsyncGenFixtureYieldType, Any],
],
runner: Runner,
request: FixtureRequest,
Expand Down Expand Up @@ -348,7 +343,7 @@ async def async_finalizer() -> None:

def _wrap_async_fixture(
fixture_function: Callable[
AsyncFixtureParams, CoroutineType[Any, Any, AsyncFixtureReturnType]
AsyncFixtureParams, CoroutineType[Any, Any, AsyncFixtureReturnType],
],
runner: Runner,
request: FixtureRequest,
Expand Down Expand Up @@ -454,7 +449,7 @@ def _from_function(cls, function: Function, /) -> Function:
@staticmethod
def _can_substitute(item: Function) -> bool:
"""Returns whether the specified function can be replaced by this class"""
raise NotImplementedError()
raise NotImplementedError

def setup(self) -> None:
runner_fixture_id = f"_{self._loop_scope}_scoped_runner"
Expand All @@ -467,7 +462,7 @@ def runtest(self) -> None:
runner = self._request.getfixturevalue(runner_fixture_id)
context = contextvars.copy_context()
synchronized_obj = _synchronize_coroutine(
getattr(*self._synchronization_target_attr), runner, context
getattr(*self._synchronization_target_attr), runner, context,
)
with MonkeyPatch.context() as c:
c.setattr(*self._synchronization_target_attr, synchronized_obj)
Expand All @@ -478,9 +473,9 @@ def _loop_scope(self) -> _ScopeName:
"""
Return the scope of the asyncio event loop this item is run in.

The effective scope is determined lazily. It is identical to to the
The effective scope is determined lazily. It is identical to the
`loop_scope` value of the closest `asyncio` pytest marker. If no such
marker is present, the the loop scope is determined by the configuration
marker is present, the loop scope is determined by the configuration
value of `asyncio_default_test_loop_scope`, instead.
"""
marker = self.get_closest_marker("asyncio")
Expand Down Expand Up @@ -526,7 +521,7 @@ def _from_function(cls, function: Function, /) -> Function:
)
async_gen_item.warn(PytestCollectionWarning(unsupported_item_type_message))
async_gen_item.add_marker(
pytest.mark.xfail(run=False, reason=unsupported_item_type_message)
pytest.mark.xfail(run=False, reason=unsupported_item_type_message),
)
return async_gen_item

Expand All @@ -541,7 +536,7 @@ class AsyncStaticMethod(PytestAsyncioFunction):
def _can_substitute(item: Function) -> bool:
func = item.obj
return isinstance(func, staticmethod) and _is_coroutine_or_asyncgen(
func.__func__
func.__func__,
)


Expand All @@ -553,11 +548,11 @@ class AsyncHypothesisTest(PytestAsyncioFunction):

def setup(self) -> None:
if not getattr(self.obj, "hypothesis", False) and getattr(
self.obj, "is_hypothesis_test", False
self.obj, "is_hypothesis_test", False,
):
pytest.fail(
f"test function `{self!r}` is using Hypothesis, but pytest-asyncio "
"only works with Hypothesis 3.64.0 or later."
"only works with Hypothesis 3.64.0 or later.",
)
return super().setup()

Expand All @@ -579,7 +574,7 @@ def _synchronization_target_attr(self) -> tuple[object, str]:
# see https://github.com/pytest-dev/pytest/issues/11307
@pytest.hookimpl(specname="pytest_pycollect_makeitem", hookwrapper=True)
def pytest_pycollect_makeitem_convert_async_functions_to_subclass(
collector: pytest.Module | pytest.Class, name: str, obj: object
collector: pytest.Module | pytest.Class, name: str, obj: object,
) -> Generator[None, pluggy.Result, None]:
"""
Converts coroutines and async generators collected as pytest.Functions
Expand Down Expand Up @@ -607,7 +602,7 @@ def pytest_pycollect_makeitem_convert_async_functions_to_subclass(
specialized_item_class = PytestAsyncioFunction.item_subclass_for(node)
if specialized_item_class:
if _get_asyncio_mode(
node.config
node.config,
) == Mode.AUTO and not node.get_closest_marker("asyncio"):
node.add_marker("asyncio")
if node.get_closest_marker("asyncio"):
Expand Down Expand Up @@ -683,7 +678,7 @@ def pytest_pyfunc_call(pyfuncitem: Function) -> object | None:
"You might want to use @pytest_asyncio.fixture or switch "
"to auto mode. "
"This will become an error in future versions of "
"pytest-asyncio."
"pytest-asyncio.",
),
stacklevel=1,
)
Expand All @@ -698,8 +693,8 @@ def pytest_pyfunc_call(pyfuncitem: Function) -> object | None:
"but it is not an async function. "
"Please remove the asyncio mark. "
"If the test is not marked explicitly, "
"check for global marks applied via 'pytestmark'."
)
"check for global marks applied via 'pytestmark'.",
),
)
yield
return None
Expand Down Expand Up @@ -761,7 +756,7 @@ def pytest_fixture_setup(fixturedef: FixtureDef, request) -> object | None:


def _get_marked_loop_scope(
asyncio_marker: Mark, default_loop_scope: _ScopeName
asyncio_marker: Mark, default_loop_scope: _ScopeName,
) -> _ScopeName:
assert asyncio_marker.name == "asyncio"
if asyncio_marker.args or (
Expand All @@ -773,7 +768,7 @@ def _get_marked_loop_scope(
raise pytest.UsageError(_DUPLICATE_LOOP_SCOPE_DEFINITION_ERROR)
warnings.warn(PytestDeprecationWarning(_MARKER_SCOPE_KWARG_DEPRECATION_WARNING))
scope = asyncio_marker.kwargs.get("loop_scope") or asyncio_marker.kwargs.get(
"scope"
"scope",
)
if scope is None:
scope = default_loop_scope
Expand Down Expand Up @@ -816,7 +811,7 @@ def _scoped_runner(
else:
with warnings.catch_warnings():
warnings.filterwarnings(
"ignore", ".*BaseEventLoop.shutdown_asyncgens.*", RuntimeWarning
"ignore", ".*BaseEventLoop.shutdown_asyncgens.*", RuntimeWarning,
)
try:
runner.__exit__(None, None, None)
Expand All @@ -831,7 +826,7 @@ def _scoped_runner(

for scope in Scope:
globals()[f"_{scope.value}_scoped_runner"] = _create_scoped_runner_fixture(
scope.value
scope.value,
)


Expand Down
32 changes: 16 additions & 16 deletions tests/test_event_loop_fixture.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ def new_event_loop(self):

# This statement represents a code which sets a custom event loop policy
asyncio.set_event_loop_policy(TestEventLoopPolicy())
"""
)
""",
),
)
pytester.makepyfile(
dedent(
Expand All @@ -48,8 +48,8 @@ async def test_custom_policy_is_not_overwritten():
across test cases.
'''
assert type(asyncio.get_event_loop()).__name__ == "TestEventLoop"
"""
)
""",
),
)
result = pytester.runpytest_subprocess("--asyncio-mode=strict")
result.assert_outcomes(passed=2)
Expand All @@ -75,11 +75,11 @@ async def generator_fn():

gen = generator_fn()
await gen.__anext__()
"""
)
""",
),
)
result = pytester.runpytest_subprocess("--asyncio-mode=strict", "-W", "default")
result.assert_outcomes(passed=1, warnings=0)
result.assert_outcomes(passed=1)


def test_closing_event_loop_in_sync_fixture_teardown_raises_warning(
Expand Down Expand Up @@ -107,14 +107,14 @@ def close_event_loop(_event_loop):
@pytest.mark.asyncio
async def test_something(close_event_loop):
await asyncio.sleep(0.01)
"""
)
""",
),
)
result = pytester.runpytest_subprocess("--asyncio-mode=strict")
result.assert_outcomes(passed=1, warnings=1)
result.stdout.fnmatch_lines(
["*An exception occurred during teardown of an asyncio.Runner*"]
)
result.assert_outcomes(passed=1)
result.stdout.fnmatch_lines([
"*An exception occurred during teardown of an asyncio.Runner*",
])


def test_event_loop_fixture_asyncgen_error(
Expand All @@ -136,8 +136,8 @@ async def test_something():
async def fail():
raise RuntimeError("mock error cleaning up...")
loop.shutdown_asyncgens = fail
"""
)
""",
),
)
result = pytester.runpytest_subprocess("--asyncio-mode=strict", "-W", "default")
result.assert_outcomes(passed=1, warnings=1)
result.assert_outcomes(passed=1)
Loading