terminal: disable OSC 9;4; terminal progress by default, except on Windows#13971
Conversation
psf-chronographer
Bot
added
the
bot:chronographer:provided
bluetech
force-pushed
the
disable-terminalprogress-by-default2
branch
from
8cb26ed to
9c9bef2
Compare
bluetech
force-pushed
the
disable-terminalprogress-by-default2
branch
from
9c9bef2 to
f95155b
Compare
|
I added two commits: some test mocking cleanup, and a fix to disable when |
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
LGTM! Thanks for tackling this solution.
|
iTerm now supports it! Screen.Recording.2025-11-19.at.12.33.20.PM.mov(not disagreeing with this solution, by the way; this makes it possible, though opt-in, to show them on iTerm. Just pointing out the macOS problem has been fixed, and users will likely be asked to upgrade like I was, so the macOS issue is going away hopefully pretty quickly.) |
|
@henryiii Nice! Hopefully we can re-enable it by default in a few releases. |
bluetech
force-pushed
the
disable-terminalprogress-by-default2
branch
from
f95155b to
992dc7f
Compare
TERM=dumb shouldn't emit escape codes like terminalprogress does, it would likely come out as literal escape characters.
bluetech
force-pushed
the
disable-terminalprogress-by-default2
branch
from
992dc7f to
beedab9
Compare
Backport to 9.0.x: 💚 backport PR created✅ Backport PR branch: Backported as #13990 🤖 @patchback |
…efault2 terminal: disable OSC 9;4; terminal progress by default, except on Windows (cherry picked from commit 66834f3)
…6834f362e38e96eb7685e21f46bdb83ba52530b/pr-13971 [PR #13971/66834f36 backport][9.0.x] terminal: disable OSC 9;4; terminal progress by default, except on Windows
3 participants
Fix #13896.
Fix #13972.
Replaces #13967, see discussion there for some more context.