fix: allow int type for truncation_limit_lines and truncation_limit_chars in TOML configs#14689
Open
muhamedfazalps wants to merge 1 commit into
Open
Conversation
…hars in TOML configs These config options were parsed as strings, causing a TypeError when users specified integer values in pyproject.toml or pytest.toml. Using type="int" allows both string and integer values. Fixes pytest-dev#14675
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
Member
There was a problem hiding this comment.
Thank you for working on this. I have a feeling that we can also avoid a bunch of int call and handling both int and string (or "no restriction" being encoded as either 0 or None), downstream later. We still need to take into account the public API that should keep working for string though. I didn't look too much into it, let me know if the scope become too big and necessitate another PR.
Member
|
Also we'd need a changelog for that I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These config options were parsed as strings, causing a TypeError when users specified integer values in pyproject.toml or pytest.toml. Using type='int' allows both string and integer values.
Fixes #14675